Skip to content

Merge pull request #2640 from woocommerce/update/2596-connect-ads-acc…

Codecov / codecov/project succeeded Oct 31, 2024 in 1s

62.7% (+0.1%) compared to a2a1e84

View this Pull Request on Codecov

62.7% (+0.1%) compared to a2a1e84

Details

Codecov Report

Attention: Patch coverage is 83.83838% with 16 lines in your changes missing coverage. Please review.

Project coverage is 62.7%. Comparing base (a2a1e84) to head (4f5bb47).

Files with missing lines Patch % Lines
js/src/hooks/useGoogleMCAccount.js 12.5% 6 Missing and 1 partial ⚠️
js/src/hooks/useAutoCreateAdsMCAccounts.js 93.8% 3 Missing ⚠️
js/src/components/account-card/index.js 77.8% 2 Missing ⚠️
js/src/components/app-select-control/index.js 87.5% 2 Missing ⚠️
js/src/hooks/useExistingGoogleAdsAccounts.js 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                          @@
##           feature/2458-streamline-onboarding   #2634     +/-   ##
====================================================================
+ Coverage                                62.7%   62.7%   +0.1%     
====================================================================
  Files                                     319     325      +6     
  Lines                                    5063    5162     +99     
  Branches                                 1233    1265     +32     
====================================================================
+ Hits                                     3173    3239     +66     
- Misses                                   1716    1746     +30     
- Partials                                  174     177      +3     
Files with missing lines Coverage Δ
...src/components/ads-account-select-control/index.js 100.0% <100.0%> (ø)
...gle-ads-account-card/connect-ads/connect-button.js 100.0% <100.0%> (ø)
...nents/google-ads-account-card/connect-ads/index.js 95.8% <100.0%> (-0.2%) ⬇️
.../components/google-combo-account-card/constants.js 100.0% <100.0%> (ø)
...components/merchant-center-select-control/index.js 100.0% <100.0%> (ø)
js/src/constants.js 100.0% <100.0%> (ø)
js/src/hooks/useCreateMCAccount.js 6.7% <ø> (ø)
js/src/components/account-card/index.js 91.9% <77.8%> (-4.9%) ⬇️
js/src/components/app-select-control/index.js 88.9% <87.5%> (-11.1%) ⬇️
js/src/hooks/useExistingGoogleAdsAccounts.js 16.7% <0.0%> (ø)
... and 2 more

... and 1 file with indirect coverage changes