-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display a notice if taxes vary by customer's shipping address #3550
Display a notice if taxes vary by customer's shipping address #3550
Conversation
@wjrosa Thanks for working on this! ✅ I see the notice for product and shortcode checkout. I set my taxes to be based on billing address and my ECE is enabled. |
Sorry about that, Anne! I just forgot about the block checkout and cart 🤦 . Can you check again, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! ✨ I was able to see the notice in product, block/shortcode cart, block/shortcode checkout when taxes are based on billing. No notices when it is not. Also did not observe any regression in the purchase process.
I added a suggestion to add wc_tax_enabled()
in the flag logic, as taxes can be disabled even when there is a legitimate value in the woocommerce_tax_based_on
option.
includes/payment-methods/class-wc-stripe-express-checkout-element.php
Outdated
Show resolved
Hide resolved
…ent.php Co-authored-by: Anne Mirasol <anne.mirasol@automattic.com>
… for existing Cash App constant
Fixes #3521
Changes proposed in this Pull Request:
This PR adds a new notice to the Express Checkout Element informing customers when rates may differ due to taxes being based on their billing address.
The notice will be shown, and the checkout process will be delayed for 700ms. Reasons for that:
Testing instructions
fix/display-notice-when-taxes-may-differ-on-ece
)is_stripe_ece_enabled
totrue
wp-admin/admin.php?page=wc-settings&tab=general
)wp-admin/admin.php?page=wc-settings&tab=tax
)wp-admin/admin.php?page=wc-settings&tab=tax
)changelog.txt
andreadme.txt
(or does not apply)Post merge