[AN/USER] feat: 메인 화면을 프래그먼트, 바텀네비게이션 구현(#92) #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re4rk
approved these changes
Jul 24, 2023
| @@ -21,4 +21,7 @@ | |||
| <string name="ticket_entry_tv_before_entry">입장 전</string> | |||
| <string name="ticket_entry_tv_after_entry">입장 완료</string> | |||
| <string name="ticket_entry_tv_away">외출중</string> | |||
| <string name="home_bottom_navigation_festival">축제 목록</string> | |||
There was a problem hiding this comment.
!-- Strings related to home --> 넣어주면 좋을 거 같아요!
| } | ||
| } | ||
|
|
||
| private inline fun <reified T : Fragment> AppCompatActivity.changeFragment() { |
SeongHoonC
reviewed
Jul 24, 2023
| @@ -37,7 +37,7 @@ class MainViewModel( | |||
|
|
|||
| fun loadTicket() { | |||
| viewModelScope.launch(exceptionHandler) { | |||
| _ticket.postValue(ticketRepository.loadTicket(0L).toPresentation()) | |||
| _ticket.postValue(ticketRepository.loadTicket(9L).toPresentation()) | |||
Comment on lines
17
to
18
| val binding = FragmentMyPageBinding.inflate(inflater) | ||
| return binding.root |
There was a problem hiding this comment.
Fragment LifeCycle 과 ViewLifeCycle 이 달라서 binding 을 놓아주는 과정이 필요할 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용