[BE] feat: 관리자 티켓 발급 구현(#117) #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokjin8678
requested changes
Jul 27, 2023
Comment on lines
190
to
198
| mockMvc.perform(post("/admin/tickets") | ||
| .content(objectMapper.writeValueAsString(request)) | ||
| .contentType(MediaType.APPLICATION_JSON)) | ||
| .andDo(print()) | ||
| .andExpect(status().isOk()) | ||
| .andExpect(jsonPath("$.id").value(ticketId)) | ||
| .andExpect(jsonPath("$.stageId").value(stageId)) | ||
| .andExpect(jsonPath("$.ticketType").value(ticketType.name())) | ||
| .andExpect(jsonPath("$.totalAmount").value(totalAmount)); |
There was a problem hiding this comment.
jsonPath를 사용하신 이유가 있나요?
There was a problem hiding this comment.
jsonPath 로 하나의 흐름을 보고 싶다는 취지였는데
변경시 직접 값들을 다 바꿔줘야한다는 점에 objectMapper 를 사용하도록 변경했습니다!
xxeol2
requested changes
Jul 27, 2023
xxeol2
reviewed
Jul 28, 2023
Comment on lines
+14
to
+16
| @DisplayNameGeneration(ReplaceUnderscores.class) | ||
| @SuppressWarnings("NonAsciiCharacters") | ||
| class TicketServiceTest extends ApplicationTest { |
There was a problem hiding this comment.
Service 테스트 어플리케이션 테스트로 하신 이유가 있나요 ?!
EntryServiceTest는 Mock으로 진행했어서요!
There was a problem hiding this comment.
xxeol2
approved these changes
Jul 28, 2023
Comment on lines
+14
to
+16
| @DisplayNameGeneration(ReplaceUnderscores.class) | ||
| @SuppressWarnings("NonAsciiCharacters") | ||
| class TicketServiceTest extends ApplicationTest { |
There was a problem hiding this comment.
carsago
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈