Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: TicketEntryTime 검증 로직 Ticket의 addTicketEntryTime 메소드로 이동 (#155) #161

Merged
merged 2 commits into from
Jul 31, 2023
Merged

[BE] feat: TicketEntryTime 검증 로직 Ticket의 addTicketEntryTime 메소드로 이동 (#155) #161

merged 2 commits into from
Jul 31, 2023

Conversation

seokjin8678
Copy link
Collaborator

@seokjin8678 seokjin8678 added BE 백엔드에 관련된 작업 ⚙️ 리팩터링 리팩터링에 관련된 작업 labels Jul 31, 2023
@seokjin8678 seokjin8678 self-assigned this Jul 31, 2023
@seokjin8678 seokjin8678 linked an issue Jul 31, 2023 that may be closed by this pull request
[BE] TicketEntryTime의 검증 로직을 Ticket의 addTicketEntryTime 메소드로 이동한다. #155
Closed
@seokjin8678 seokjin8678 changed the title [BE] feat: [BE] TicketEntryTime 검증 로직 Ticket의 addTicketEntryTime 메소드로 이동 (#155) [BE] feat: TicketEntryTime 검증 로직 Ticket의 addTicketEntryTime 메소드로 이동 (#155) Jul 31, 2023
@github-actions
Copy link

Unit Test Results

69 tests  ±0   69 ✔️ ±0   2s ⏱️ ±0s
27 suites ±0     0 💤 ±0 
27 files   ±0     0 ❌ ±0 

Results for commit af6ff1f. ± Comparison against base commit c7181c3.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both. 
com.festago.domain.TicketEntryTimeTest ‑ [1] entryTime=2023-07-26T18:00:00
com.festago.domain.TicketEntryTimeTest ‑ [2] entryTime=2023-07-26T18:00:01
com.festago.domain.TicketEntryTimeTest ‑ 입장 시간이 공연 시작 12시간 이전이면 예외

com.festago.domain.TicketTest ‑ [1] minute=0
com.festago.domain.TicketTest ‑ [2] minute=1
com.festago.domain.TicketTest ‑ 입장 시간이 공연 시작 12시간 이전이면 예외

carsago
carsago approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@carsago carsago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전에 읽었었고, 단순히 로직은 옮긴거에 가깝기 때문에 approve 합니다.

@seokjin8678 seokjin8678 merged commit e16fdd5 into dev Jul 31, 2023
8 checks passed
@seokjin8678 seokjin8678 deleted the feat/#155 branch July 31, 2023 06:07
re4rk pushed a commit that referenced this pull request Jul 31, 2023
@seokjin8678 @re4rk
[BE] refactor: TicketEntryTime 검증 로직 Ticket으로 이동 (#161) (#162)
8f9d3f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BGuga BGuga Awaiting requested review from BGuga

@carsago carsago Awaiting requested review from carsago

@xxeol2 xxeol2 Awaiting requested review from xxeol2

Assignees

@seokjin8678 seokjin8678

Labels
BE 백엔드에 관련된 작업 ⚙️ 리팩터링 리팩터링에 관련된 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] TicketEntryTime의 검증 로직을 Ticket의 addTicketEntryTime 메소드로 이동한다.
3 participants
@seokjin8678 @xxeol2 @carsago