[FE] 페어룸 만들기, 페어룸 유형 선택하기 접근성 개선 #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greetings1012
commented
Oct 17, 2024
There was a problem hiding this comment.
중복된 button 태그를 제거하고 tabIndex 추가
greetings1012
commented
Oct 17, 2024
Comment on lines
16
to
20
| if (focusableElements.current[0].getAttribute('aria-label') === '모달 닫기') { | ||
| focusableElements.current[1]?.focus(); | ||
| } else { | ||
| focusableElements.current[0].focus(); | ||
| } |
There was a problem hiding this comment.
모달의 첫 번째 요소가 닫기 버튼이면 두 번째 요소, 아니면 첫 번째 요소에 자동으로 포커스
There was a problem hiding this comment.
이 코드가 추가되면서 모달이 열리면 포커스가 첫 버튼에 고정되는 현상이 있더라고요 😭 그래서 제가 작업할 때 해당 코드를 제거하게 되었습니다...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
상세 설명
파란
alt및aria-label추가파슬리
alt="메인 로고"를alt="코딩해듀오 로고"로 변경했습니다.<main>태그를 읽고 있어서role="presentation"으로 읽지 않도록 변경했습니다.aria-label과role="presentation"설정했습니다.useFocusTrap커스텀 훅의 변경 사항을 제거했습니다.useAriaTrap커스텀 훅을 추가로 구현했습니다.