-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 회고 페이지 구현 #828
base: FE/dev
Are you sure you want to change the base?
[FE] 회고 페이지 구현 #828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! 몇 가지 궁금한 사항 남겨두었으니 시간날 때 확인해주세요!
path: 'retrospect', | ||
element: <Retrospect readOnly={false} />, | ||
}, | ||
{ | ||
path: 'retrospect/:retrospectId', | ||
element: <Retrospect />, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희 회고 한번 하면 수정 못하나요...?
const renderAnswer = (index: number, id: string) => ( | ||
<S.Textarea | ||
placeholder="질문에 대한 답변을 작성해주세요." | ||
id={id} | ||
value={answers[index]} | ||
onChange={(event) => handleChange(index, event.target.value)} | ||
/> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컴포넌트로 분리해주세요 🥲
}, | ||
}; | ||
else | ||
return { | ||
title: '회고 작성하기', | ||
buttonText: '나중에 작성하기', | ||
onButtonClick: () => { | ||
alert('나중에 작성하시겠습니까?'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alert 대신 간단한 모달은 어떤가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파일명에 오타가 있네요!
연관된 이슈
구현한 기능
상세 설명
공통 부분
다른 부분
editable
readOnly
컴포넌트 설명
(공통)
(공통)
(공통)