[BE] 리뷰 서비스 리팩토링(#615) #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
youngsu5582
force-pushed
the
feat/#615
branch
from
8940102
to
4a40fe2
Compare
Test Results 55 files 55 suites 8s ⏱️ Results for commit 4a40fe2. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
리뷰 서비스 리팩토링 했습니다.
느낀점으로 엄청난 코드 퀄리티 변화가 있진 않았다? 인거 같아요.
( 외부 API 를 사용하는 로직 분리하고 싶었으나,
조회 -> 외부 API 호출 -> 다시 수정과 같이 매우 비효율 적 로직이 되어 버림 )( 로직도, 단순 Reader - Writer 로 빠진게 전부 + Writer 가 다소 의아한데 이는 엔티티의 설게적으로 의심을 할 거 같아요
-> 리뷰가 됐으면 리뷰 라는 엔티티가 생겨서 이를 통해 리뷰 완료를 한다면, 납득 가능 )
p.s 컨벤션 맞추려고 열심히 정렬 한땀 한땀 했는데 안됐으면 죄송합니다. 🥲