feat-fe: 랜딩 페이지 반응형 디자인 추가 #775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1729236688.020229 |
|
1729236688.431759 |
|
1729236750.701789 |
lurgi
approved these changes
Oct 18, 2024
| const scrollToTop = () => { | ||
| window.scrollTo({ top: 0, behavior: 'smooth' }); | ||
| }; | ||
|
|
||
| const scrollToMain = () => { |
Comment on lines
-42
to
67
| const getBubblePosition = (index: number) => { | ||
| const positions = [ | ||
| const getBubblePosition = (index: number, isMobile?: boolean) => { | ||
| const desktopPositions = [ | ||
| { top: '10%', right: '10%' }, | ||
| { top: '10%', left: '10%' }, | ||
| { top: '40%', right: '5%' }, | ||
| { top: '40%', left: '5%' }, | ||
| ]; | ||
| return positions[index] || positions[0]; | ||
|
|
||
| const mobilePositions = [ | ||
| { right: '5%', top: '10%' }, | ||
| { left: '5%', top: '10%' }, | ||
| { right: '0', top: '40%' }, | ||
| { left: '0', top: '40%' }, | ||
| ]; | ||
|
|
||
| const position = isMobile | ||
| ? mobilePositions[index] || mobilePositions[0] | ||
| : desktopPositions[index] || desktopPositions[0]; | ||
|
|
||
| return css` | ||
| ${position.top ? `top: ${position.top};` : ''} | ||
| ${position.right ? `right: ${position.right};` : ''} | ||
| ${position.left ? `left: ${position.left};` : ''} | ||
| `; | ||
| }; |
There was a problem hiding this comment.
코드 너무 잘 짜셨어요 너무 멋져요 어떻게 이런 생각을....
There was a problem hiding this comment.
함수명이 영 별로네요
지킬과 하이드 같네요
Comment on lines
+311
to
+314
| ${index === 0 ? 'right: 5%;' : ''} | ||
| ${index === 1 ? 'left: 5%;' : ''} | ||
| ${index === 2 ? 'right: 0;' : ''} | ||
| ${index === 3 ? 'left: 0;' : ''} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
작업 내용
(gif로 내보내니까 배경의 그라디언트가 깨지네요.🥲 실제로는 정상적으로 보입니다.)
LAND_02
closes #774