Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS 설정 수정 #88

Merged
merged 3 commits into from
Jul 25, 2024
Merged

CORS 설정 수정 #88

merged 3 commits into from
Jul 25, 2024

Conversation

ksk0605
Copy link
Contributor

@ksk0605 ksk0605 commented Jul 22, 2024

PR의 목적이 무엇인가요?

이슈 ID는 무엇인가요?

설명

  • url 패턴 전체허용
  • 메소드 GET, POST, DELETE 허용
  • Authorization, Content-Type 헤더 허용
  • credential 적용

질문 혹은 공유 사항 (Optional)

Copy link
Contributor

@ay-eonii ay-eonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요 테바 👍
블로그 글도 감사합닌다 ~

Copy link
Contributor

@hoyeonyy hoyeonyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테바 글도 쓰고 코드도 고치느랴 수고 많았습니다,,

method에 관한게 궁금해서 코멘트 하나 남겼습니다!

.allowedMethods("*")
.allowedHeaders("*");
.allowedOrigins("http://localhost:8080")
.allowedMethods("GET", "POST", "DELETE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTION 을 넣지 않아도 괜찮나요?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실제 작동 테스트를 해보니 작동이 잘 되더라구요..?
그래도 명시적으로 작성해놓는게 좋으니 수정하겠습니다!

@ksk0605 ksk0605 merged commit a660d09 into develop-backend Jul 25, 2024
1 check passed
@ss0526100 ss0526100 deleted the refactor/#87 branch July 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants