[BE-FEAT] 기술 관련 api 만들기 #360
Merged
+151
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongmee
requested changes
Oct 14, 2024
| @@ -31,14 +37,26 @@ public ApiResponse<List<MoveResponse>> moveListByPokedexNumber(@RequestParam("po | |||
| } | |||
|
|
|||
| @GetMapping("/api/v1/move/{id}") | |||
| public ApiResponse<MoveResponse> moveDetails(@PathVariable String id) { | |||
| public ApiResponse<MoveResponse> moveDetailsByBattle(@PathVariable String id) { | |||
There was a problem hiding this comment.
이 메소드들(서비스 메소드 포함) moveDetailsInBattle 어때요 ?!
| return new ApiResponse<>("기술 정보 불러오기에 성공했습니다.", moveService.findMoveByBattle(id)); | ||
| } | ||
|
|
||
| @GetMapping("/api/v1/move1/{id}") |
There was a problem hiding this comment.
지금 사용되고 있는 move1 대신에 /api/v1/move-dex/{id}나 /api/v1/move/dex/{id}어떤가요
'기술 도감' 이어서 생각났어요! 배틀 관련 기술 api에 battle 붙이고 싶지만 하위호환성 때문에 그건 안될 거 같고.. 🥲
unifolio0
force-pushed
the
be/feat/#359-get-move-api
branch
from
da6e7a3
to
90118fd
Compare
jinchiim
requested changes
Oct 15, 2024
backend/pokerogue/src/main/java/com/pokerogue/helper/move/service/MoveService.java
Outdated
Show resolved
Hide resolved
|
/noti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍄 PR 확인 사항
PR이 다음 요구 사항을 충족하는지 확인하세요. :
현재 작업은 어떤 이슈를 해결한 것인지 설명해주세요.
기존 코드에서 변경된 점이 있다면 설명해주세요. (추가 X)
우선 이 정보가 들어가면 되겠지 하고 짠 코드입니다.
추가로 기존에 존재하던 api와 중복 문제 때문에 임시로 api를 대충 만들었는데 어떻게 할 지 정해야 될 것 같아요