-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.1.1/AN-FEAT] 페이지 이동 로직 개선 #379
Open
JoYehyun99
wants to merge
11
commits into
an/develop
Choose a base branch
from
an/feat/page-navigation
base: an/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ff06fe0
feat: 포켓몬 아이디를 통해 새로운 포켓몬 선택 기능
JoYehyun99 bd55756
feat: intent를 통해 선택 타입 및 포켓몬 아이디 받기
JoYehyun99 6f542d9
ui: 바이옴 디테일 페이지에 배틀 페이지 이동 모드 토글 버튼 설정
JoYehyun99 ca6d4fc
feat: 이동 모드에 따라 다르게 페이지 이동
JoYehyun99 dd61ee1
feat: 이동 모드 설정값 datastore에 저장
JoYehyun99 09d4095
chore: balloon gradle 설정
JoYehyun99 fb1eaa1
feat: tooltip 안내 메세지 제공
JoYehyun99 63b137a
fix: 포켓몬 선택 저장 기능 반영
JoYehyun99 a46170a
feat: 새로운 datastore 파일 Koin 적용
JoYehyun99 e7d1910
ui: 작은 화면 대응
JoYehyun99 66068c8
chore: 린트 설정 완화
JoYehyun99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
android/app/src/main/java/poke/rogue/helper/presentation/battle/SelectionType.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package poke.rogue.helper.presentation.battle | ||
|
||
enum class SelectionType { | ||
MINE, | ||
OPPONENT, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
바뀐 코드가 개행 밖에 없는데 왜 이런 일이 생기는 거죠.. ?
이게 생각보다 코드 리뷰할 때 귀찮게 하긴 하네요 😲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러게요,,,? 다시 확인 해볼께용