-
Notifications
You must be signed in to change notification settings - Fork 309
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
83 additions
and
0 deletions.
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
tomcat/src/main/java/org/apache/coyote/controller/AbstractController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package org.apache.coyote.controller; | ||
|
||
import org.apache.coyote.controller.exception.UnsupportedRequestMethodException; | ||
import org.apache.coyote.httprequest.HttpRequest; | ||
import org.apache.coyote.httprequest.RequestMethod; | ||
import org.apache.coyote.httpresponse.HttpResponse; | ||
|
||
public abstract class AbstractController implements Controller { | ||
|
||
@Override | ||
public void service(final HttpRequest httpRequest, final HttpResponse httpResponse) { | ||
if (httpRequest.isSameRequestMethod(RequestMethod.GET)) { | ||
doGet(httpRequest, httpResponse); | ||
return; | ||
} | ||
if (httpRequest.isSameRequestMethod(RequestMethod.POST)) { | ||
doPost(httpRequest, httpResponse); | ||
return; | ||
} | ||
throw new UnsupportedRequestMethodException(); | ||
} | ||
|
||
protected abstract void doPost(final HttpRequest httpRequest, final HttpResponse httpResponse); | ||
|
||
protected abstract void doGet(final HttpRequest httpRequest, final HttpResponse httpResponse); | ||
} |
9 changes: 9 additions & 0 deletions
9
tomcat/src/main/java/org/apache/coyote/controller/Controller.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package org.apache.coyote.controller; | ||
|
||
import org.apache.coyote.httprequest.HttpRequest; | ||
import org.apache.coyote.httpresponse.HttpResponse; | ||
|
||
public interface Controller { | ||
|
||
void service(final HttpRequest httpRequest, final HttpResponse httpResponse); | ||
} |
8 changes: 8 additions & 0 deletions
8
...c/main/java/org/apache/coyote/controller/exception/UnsupportedRequestMethodException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package org.apache.coyote.controller.exception; | ||
|
||
public class UnsupportedRequestMethodException extends IllegalArgumentException { | ||
|
||
public UnsupportedRequestMethodException() { | ||
super("지원하지 않는 Request Method 입니다."); | ||
} | ||
} |
40 changes: 40 additions & 0 deletions
40
tomcat/src/test/java/org/apache/coyote/controller/AbstractControllerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package org.apache.coyote.controller; | ||
|
||
import org.apache.coyote.controller.exception.UnsupportedRequestMethodException; | ||
import org.apache.coyote.httprequest.HttpRequest; | ||
import org.apache.coyote.httpresponse.HttpResponse; | ||
import org.apache.coyote.httpresponse.handler.HandlerTestSupport; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.assertj.core.api.Assertions.*; | ||
|
||
@SuppressWarnings("NonAsciiCharacters") | ||
class AbstractControllerTest extends HandlerTestSupport { | ||
|
||
@Test | ||
void 지원하지_않는_메소드에_대해_예외를_터트린다() { | ||
// given | ||
final String input = String.join("\r\n", | ||
"DELETE /login HTTP/1.1", | ||
"Host: localhost:8080", | ||
"Connection: keep-alive", | ||
"Accept: */*"); | ||
final HttpRequest httpRequest = super.makeHttpRequest(input); | ||
final HttpResponse httpResponse = HttpResponse.init(httpRequest.getHttpVersion()); | ||
|
||
// when | ||
final AbstractController abstractController = new AbstractController() { | ||
@Override | ||
protected void doPost(final HttpRequest httpRequest, final HttpResponse httpResponse) { | ||
} | ||
|
||
@Override | ||
protected void doGet(final HttpRequest httpRequest, final HttpResponse httpResponse) { | ||
} | ||
}; | ||
|
||
// then | ||
assertThatThrownBy(() -> abstractController.service(httpRequest, httpResponse)) | ||
.isInstanceOf(UnsupportedRequestMethodException.class); | ||
} | ||
} |