[톰캣] - 1,2 단계 박스터 미션 제출합니다 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
jyeost
approved these changes
Sep 4, 2023
|
|
||
| import java.util.Arrays; | ||
|
|
||
| public enum ContentType { |
| while (isNotEmpty(line)) { | ||
| String[] splitedLine = line.split(":", 2); | ||
|
|
||
| String key = splitedLine[KEY_INDEX].toLowerCase(); |
There was a problem hiding this comment.
request header부분만 lowerCase로 변경해주던데
이유가 궁금합니더 !
| String line = bufferedReader.readLine(); | ||
|
|
||
| while (isNotEmpty(line)) { | ||
| String[] splitedLine = line.split(":", 2); |
| import org.apache.coyote.http11.common.HttpMethod; | ||
| import org.apache.coyote.http11.common.HttpVersion; | ||
|
|
||
| public class RequestLine { |
There was a problem hiding this comment.
이부분 클래스 명이 조금 모호한것 같아서
RequestStartLine 으로 변경 제안 드립니당@!
| responseHeaders.addCookie(cookie); | ||
| } | ||
|
|
||
| @Override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
케로 안녕하세요
이상입니다. 설명이 짧다면 디엠 주세요