Flop.Phoenix.pagination change to allow not to render next/prev links

[oliverswitzer]

Description

Thanks for making this awesome library!

This PR adds the ability to specify that you do not wanter to render next and previous links.

Background: we're experiencing a styling conflict with our UI library daisyUI that causes the nubmered pages left border radius to get cut off when next / prev links are rendered (which we do not want).

This feature allows you to disable rendering those buttons if they aren't wanted.

Checklist

• [ x] I added tests that cover my proposed changes.
• [ x] I updated the documentation related to my changes (if applicable).

[cadebward]

FYI. I was able to solve the same thing with the built in options. For example, I hid the page numbers with:

def pagination_opts do
  [
    pagination_list_attrs: [class: "hidden"],
  ]
end

[woylie]

FYI. I was able to solve the same thing with the built in options. For example, I hid the page numbers with:

def pagination_opts do
  [
    pagination_list_attrs: [class: "hidden"],
  ]
end

Do you still think the changes in this PR would be useful, or are you happy with the CSS solution?

[coveralls]

coverage: 100.0%. remained the same when pulling 322d121 on oliverswitzer:update-pagination-component into 12e6c15 on woylie:main.

[cadebward]

I am personally happy with the CSS solution, but curious to hear what @oliverswitzer thinks.

[oliverswitzer]

Hey friends, sorry, been a busy couple of weeks!

To be clear I wasn't hoping to hide page numbers entirely, which seems like what the solution @cadebward was recommending (pagination_list_attrs: [class: "hidden"]) would do, but instead fix the issue shown in the screenshot where the border radius of the left most pagination number is cut off due to the presence of the "previous" button in the list.

Even if I try to hide the previous and next buttons with setting next_link_attrs={[class: "hidden"]} and previous_link_attrs={[class: "hidden"]}, this issue still persists due to the element still being present in the DOM. daisyUI's join class selector (used in their pagination component) is treating the previous button as the first element that needs a border-radius left applied, even though it is technically "display: none"... As a result the actual first element that should be visible in the list (ie the 1st page button) is not getting the proper border radius. I hope that makes sense.

I think next/prev elements need to not be rendered in the DOM entirely to fix this issue.

[woylie]

Little nitpick, the options here are in alphabetical order, can you move the new option to the right position?

[woylie]

This list is alphabetically sorted as well. 🔤

[woylie]

Hey friends, sorry, been a busy couple of weeks!

To be clear I wasn't hoping to hide page numbers entirely, which seems like what the solution @cadebward was recommending (pagination_list_attrs: [class: "hidden"]) would do, but instead fix the issue shown in the screenshot where the border radius of the left most pagination number is cut off due to the presence of the "previous" button in the list.

Even if I try to hide the previous and next buttons with setting next_link_attrs={[class: "hidden"]} and previous_link_attrs={[class: "hidden"]}, this issue still persists due to the element still being present in the DOM. daisyUI's join class selector (used in their pagination component) is treating the previous button as the first element that needs a border-radius left applied, even though it is technically "display: none"... As a result the actual first element that should be visible in the list (ie the 1st page button) is not getting the proper border radius. I hope that makes sense.

I think next/prev elements need to not be rendered in the DOM entirely to fix this issue.

Alright, let's add the option. I just had two small comments.