refactor tokenissuer #1940
Closed
refactor tokenissuer #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharindu1st
force-pushed
the
proto-move
branch
from
ffdf09c
to
d9f76dc
Compare
tharindu1st
added
the
trigger-action
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1940 +/- ##
==========================================
- Coverage 26.53% 26.52% -0.02%
==========================================
Files 124 124
Lines 14516 14523 +7
Branches 2575 2575
==========================================
Hits 3852 3852
- Misses 10540 10547 +7
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tharindu1st
force-pushed
the
proto-move
branch
from
d9f76dc
to
e6fa4d8
Compare
github-actions
bot
removed
the
trigger-action
tharindu1st
added
the
trigger-action
pubudu538
reviewed
Jan 10, 2024
| // } | ||
| // UpdateEnforcerJWTIssuers(jwtIssuerMapping) | ||
| // return ctrl.Result{}, nil | ||
| } |
There was a problem hiding this comment.
Let's remove commented code.
pubudu538
reviewed
Jan 10, 2024
| @@ -0,0 +1,27 @@ | |||
| package org.wso2.apk.enforcer.subscription; | |||
pubudu538
reviewed
Jan 10, 2024
| @@ -0,0 +1,27 @@ | |||
| package org.wso2.apk.enforcer.subscription; | |||
There was a problem hiding this comment.
License header? Please check other locations.
tharindu1st
force-pushed
the
proto-move
branch
from
e6fa4d8
to
201856a
Compare
github-actions
bot
removed
the
trigger-action
tharindu1st
added
the
trigger-action
tharindu1st
force-pushed
the
proto-move
branch
from
201856a
to
66fcea4
Compare
github-actions
bot
removed
the
trigger-action
tharindu1st
added
the
trigger-action
ShammiL
reviewed
Jun 4, 2024
Comment on lines
+1553
to
+1557
| if (tokenIssuerBuilder_ == null) { | ||
| return tokenIssuer_ == null ? org.wso2.apk.enforcer.discovery.subscription.TokenIssuer.getDefaultInstance() : tokenIssuer_; | ||
| } else { | ||
| return tokenIssuerBuilder_.getMessage(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (tokenIssuerBuilder_ == null) { | |
| return tokenIssuer_ == null ? org.wso2.apk.enforcer.discovery.subscription.TokenIssuer.getDefaultInstance() : tokenIssuer_; | |
| } else { | |
| return tokenIssuerBuilder_.getMessage(); | |
| } | |
| if (tokenIssuerBuilder_ == null) { | |
| return tokenIssuer_ == null ? org.wso2.apk.enforcer.discovery.subscription.TokenIssuer.getDefaultInstance() : tokenIssuer_; | |
| } | |
| return tokenIssuerBuilder_.getMessage(); |
github-actions
bot
removed
the
trigger-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor tokenissuer