Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandate Enforcer availability for the Router #2213

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

pubudu538
Copy link
Contributor

Purpose

Fixes #2207

This mandates Enforcers availability when checking the readiness of the Router. Earlier, Router starts accepting requests without considering the availability of the Enforcer.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@pubudu538 pubudu538 added the trigger-action When this includes apk actions getting trigger for pr label Mar 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.79%. Comparing base (ae75260) to head (2b32250).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2213      +/-   ##
==========================================
+ Coverage   25.56%   27.79%   +2.22%     
==========================================
  Files          47      124      +77     
  Lines        9394    14674    +5280     
  Branches        0     2681    +2681     
==========================================
+ Hits         2402     4078    +1676     
- Misses       6861    10465    +3604     
  Partials      131      131              
Flag Coverage Δ
adapter 27.38% <ø> (+0.05%) ⬆️
common-controller 4.07% <ø> (ø)
config-deployer-service 25.99% <ø> (?)
idp-domain-service 80.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krishanx92 Krishanx92 merged commit 539f399 into wso2:main Apr 1, 2024
12 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router's readiness should be depend on the Enforcer's readiness
4 participants