Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #618

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Update documentation #618

merged 8 commits into from
Sep 25, 2024

Conversation

hvge
Copy link
Member

@hvge hvge commented Sep 11, 2024 •
edited
Loading

This PR fixes multiple issues found in documentation:

  • Added documentation for advanced configuration objects, such as PowerAuthKeychainConfiguration
  • Added warning about usage of UIDevice.current.name
  • Better activation states documentation (issue with unclear deadlock state)
  • Better activation data sharing documentation
  • Fixed wrong examples in instance config, still using APP_KEY, APP_SECRET, style of config

You can review it on per-commit basis.

@hvge hvge mentioned this pull request Sep 18, 2024
Merged
@hvge hvge marked this pull request as ready for review September 23, 2024 15:38
@hvge hvge requested a review from kober32 September 23, 2024 15:38
kober32
kober32 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, just minor remarks to consider.

docs/PowerAuth-SDK-for-Android.md Outdated Show resolved Hide resolved
docs/PowerAuth-SDK-for-Android.md Outdated Show resolved Hide resolved
docs/PowerAuth-SDK-for-Android.md Outdated Show resolved Hide resolved
docs/PowerAuth-SDK-for-iOS.md Outdated Show resolved Hide resolved
docs/PowerAuth-SDK-for-iOS.md Outdated Show resolved Hide resolved
@hvge hvge merged commit d06e8dc into develop Sep 25, 2024
1 check passed
@hvge hvge deleted the issues/documentation-update branch September 25, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 kober32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvge @kober32