Fix #1576: Excessive logging of CreatePersonalizedOfflineSignaturePay…

…loadResponse (#1662) * Fix #1576: Excessive logging of CreatePersonalizedOfflineSignaturePayloadResponse * Do not log the whole object on info level Co-authored-by: Zdeněk Černý <zdenek.cerny@wultra.com>
wultra · Oct 10, 2024 · 689fc92 · 689fc92
1 parent d750a6d
commit 689fc92
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/...rity/powerauth/client/model/request/CreatePersonalizedOfflineSignaturePayloadRequest.java b/...rity/powerauth/client/model/request/CreatePersonalizedOfflineSignaturePayloadRequest.java
@@ -36,6 +36,7 @@ public class CreatePersonalizedOfflineSignaturePayloadRequest {
     private String data;
 
     @Schema(description = "Optional nonce (16 bytes base64 encoded into 24 characters), otherwise it will be generated by PowerAuth server. Needed to be set when proximity check is enabled.", maxLength = 24)
+    @ToString.Exclude
     private String nonce;
 
     @Schema(description = "Optional proximity check configuration of TOTP.")

diff --git a/...ain/java/io/getlime/security/powerauth/app/server/controller/api/SignatureController.java b/...ain/java/io/getlime/security/powerauth/app/server/controller/api/SignatureController.java
@@ -81,9 +81,11 @@ public ObjectResponse<VerifySignatureResponse> verifySignature(@RequestBody Obje
      */
     @PostMapping("/offline/personalized/create")
     public ObjectResponse<CreatePersonalizedOfflineSignaturePayloadResponse> createPersonalizedOfflineSignaturePayload(@RequestBody ObjectRequest<CreatePersonalizedOfflineSignaturePayloadRequest> request) throws Exception {
-        logger.info("CreatePersonalizedOfflineSignaturePayloadRequest received: {}", request);
+        logger.info("action: createPersonalizedOfflineSignaturePayload, state: initiated, activationId: {}", request.getRequestObject().getActivationId());
+        logger.debug("action: createPersonalizedOfflineSignaturePayload, state: initiated, {}", request);
         final ObjectResponse<CreatePersonalizedOfflineSignaturePayloadResponse> response = new ObjectResponse<>(offlineSignatureService.createPersonalizedOfflineSignaturePayload(request.getRequestObject()));
-        logger.info("CreatePersonalizedOfflineSignaturePayloadRequest succeeded: {}", response);
+        logger.info("action: createPersonalizedOfflineSignaturePayload, state: succeeded");
+        logger.debug("action: createPersonalizedOfflineSignaturePayload, state: succeeded, {}", response);
         return response;
     }
 
@@ -96,9 +98,11 @@ public ObjectResponse<CreatePersonalizedOfflineSignaturePayloadResponse> createP
      */
     @PostMapping("/offline/non-personalized/create")
     public ObjectResponse<CreateNonPersonalizedOfflineSignaturePayloadResponse> createNonPersonalizedOfflineSignaturePayload(@RequestBody ObjectRequest<CreateNonPersonalizedOfflineSignaturePayloadRequest> request) throws Exception {
-        logger.info("CreateNonPersonalizedOfflineSignaturePayloadRequest received: {}", request);
+        logger.info("action: createNonPersonalizedOfflineSignaturePayload state: initiated, activationId: {}", request.getRequestObject().getApplicationId());
+        logger.debug("action: createNonPersonalizedOfflineSignaturePayload state: initiated, {}", request);
         final ObjectResponse<CreateNonPersonalizedOfflineSignaturePayloadResponse> response = new ObjectResponse<>(offlineSignatureService.createNonPersonalizedOfflineSignaturePayload(request.getRequestObject()));
-        logger.info("CreateNonPersonalizedOfflineSignaturePayloadRequest succeeded: {}", response);
+        logger.info("action: createNonPersonalizedOfflineSignaturePayload state: succeeded");
+        logger.debug("action: createNonPersonalizedOfflineSignaturePayload state: succeeded, {}", response);
         return response;
     }