fix #4

wzv5 · Jul 21, 2023 · b3cf11e · b3cf11e
1 parent b0c24d2
commit b3cf11e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/pkg/ping/http.go b/pkg/ping/http.go
@@ -74,10 +74,14 @@ func (this *HttpPing) PingContext(ctx context.Context) IPingResult {
 			return this.errorResult(err)
 		}
 	}
+	ipstr := ip.String()
+	if isIPv6(ip) {
+		ipstr = fmt.Sprintf("[%s]", ipstr)
+	}
 	if port != "" {
-		u.Host = net.JoinHostPort(ip.String(), port)
+		u.Host = fmt.Sprintf("%s:%s", ipstr, port)
 	} else {
-		u.Host = ip.String()
+		u.Host = ipstr
 	}
 	url2 := u.String()
 

diff --git a/test/pping_test.go b/test/pping_test.go
@@ -99,3 +99,12 @@ func TestQuic(t *testing.T) {
 		t.Fatal(result.Error())
 	}
 }
+
+func TestHttpIPv6(t *testing.T) {
+	p := ping.NewHttpPing("GET", "https://www.qq.com/", time.Second*5)
+	p.IP, _ = ping.LookupIPv6("www.qq.com")
+	result := p.Ping()
+	if result.Error() != nil {
+		t.Fatal(result.Error())
+	}
+}