Add more GitHub import API support #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types.go
Outdated
| const ( | ||
| Optimistic ImportTimeoutStrategy = "optimistic" | ||
| Pessimistic ImportTimeoutStrategy = "pessimistic" | ||
| ) |
There was a problem hiding this comment.
I don't see any code using this type. If that is correct, why did you add it and/or should it be deleted instead?
There was a problem hiding this comment.
You were right, it wasn't being used. I was originally planning to add the BitBucket import API endpoints as well, which was using this type but the API documentation in GitLab was incomplete so I decided to take it out for now. I missed this type though, good catch, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Import API endpoints for cancelling a GitHub import and importing GitHub gists into personal GitLab snippets.