Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WebURL field to LastPipeline #1955

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

nareshanamana
Copy link
Contributor

https://docs.gitlab.com/ee/api/pipeline_schedules.html#get-a-single-pipeline-schedule

GET /projects/:id/pipeline_schedules/:pipeline_schedule_id response structure from GitLab 16.7:

{
  "id": "",
  "description": "",
  "ref": "",
  "cron": "",
  "cron_timezone": "",
  "next_run_at": "",
  "active": "",
  "created_at": "",
  "updated_at": "",
  "owner": {
    "id": "",
    "username": "",
    "name": "",
    "state": "",
    "locked": "",
    "avatar_url": "",
    "web_url": ""
  },
  "last_pipeline": {
    "id": "",
    "iid": "",
    "project_id": "",
    "sha": "",
    "ref": "",
    "status": "",
    "source": "",
    "created_at": "",
    "updated_at": "",
    "web_url": ""
  },
  "variables": []
}

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I prefer to only add fields that are documented to prevent issues when undocumented stuff changes. But for this one I'm OK with the change. So thanks @nareshanamana 👍🏻

@svanharmelen svanharmelen merged commit 5e29e97 into xanzy:main Jun 11, 2024
3 checks passed
@nareshanamana
Copy link
Contributor Author

Thanks! I was hesitant to add the remaining ones for that reason. Ideally GitLab would document everything. 🥴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants