Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose PreReceiveSecretDetectionEnabled project setting #1984

Merged

Conversation

gravis
Copy link
Contributor

@gravis gravis commented Aug 9, 2024

This change adds the PreReceiveSecretDetectionEnabled field to the Project struct. This boolean reflects the state of the project Secret Push Protection feature: https://docs.gitlab.com/ee/user/application_security/secret_detection/secret_push_protection/

See also https://gitlab.com/gitlab-org/gitlab/-/merge_requests/160960

This change adds the `PreReceiveSecretDetectionEnabled` field to the
`Project` struct. This boolean reflects the state of the project Secret
Push Protection feature:
https://docs.gitlab.com/ee/user/application_security/secret_detection/secret_push_protection/
See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/160960
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually don't merge PRs that add undocumented fields as I don't consider them part of the public API (if not documented it can change at any time without an indication other then in the source code), but I'll take this one as I expect it will stay around 👍🏻

@svanharmelen svanharmelen merged commit e129792 into xanzy:main Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants