Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PreReceiveSecretDetectionEnabled to Project #1989

Merged

Conversation

gravis
Copy link
Contributor

@gravis gravis commented Aug 18, 2024

It was added to the wrong location with !1984

It was added to the wrong location with !1984
@gravis
Copy link
Contributor Author

gravis commented Aug 18, 2024

Sorry for that!

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this is why I normally don't merge PRs with undocumented features 😏

projects.go Outdated Show resolved Hide resolved
Co-authored-by: Sander van Harmelen <sander@vanharmelen.nl>
@gravis
Copy link
Contributor Author

gravis commented Aug 19, 2024

Guess this is why I normally don't merge PRs with undocumented features 😏

@svanharmelen The documentation for this feature is here, but I think you are referring to https://docs.gitlab.com/ee/api/projects.html#get-single-project?

@svanharmelen
Copy link
Member

Yes indeed... But all is good. Thanks for fixing the issue 👍🏻

@svanharmelen svanharmelen merged commit 5f1ec68 into xanzy:main Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants