-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix Precropping issue #71
base: main
Are you sure you want to change the base?
Conversation
_reCenterImage function now takes into account child widget aspect ratio when calculating boundaries for offset clamping.
Rescaling of dimensions needs to be done depending of image orientation. Previous implementation works correct only for horizontal images.
Yes. That is intended. I described that in github issue. For our purpose, the current behaviour is intended so that is how it works now. If you would like to have it work like before with limiting the pan to the inside of the picture then the calculation needs to be more complex. |
It's good to have an option of disabling this behavior. But i think it's best to have it enabled by default. What do you think? |
Animations also come handy to have as another option. |
Yeah, both animation and that behaviour could be parametrized. |
I appreciate your efforts. |
Sorry @xclud but I cannot find the time right now to finish that changes as proposed. Maybe I will have more time to finish that in the new year, but right now changes won't happen. So if you have time to finish that goes on, if not then let's wait. |
If we disable rotation like this PR #66 and combine it with this Bugfix Precropping PR, then everything works perfectly. |
This problem has been solved, I use zoom, rotation, and the crop, in my system, but the crop if you slide it to the position you want to crop it comes back by itself, is it some configuration or is it really with the gub, and congratulations by packge! |
_reCenterImage function now takes into account child widget aspect
ratio when calculating boundaries for offset clamping.