Fixup perfmon #10

bernhardkaindl · 2024-01-30T23:11:00Z

No description provided.

Signed-off-by: Stephen Cheng <stephen.cheng@cloud.com>

codecov-commenter · 2024-01-30T23:12:11Z

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ee472c7) 45.38% compared to head (3fb1ed0) 46.71%.

Files	Patch %	Lines
scripts/perfmon	0.00%	4 Missing ⚠️
scripts/hfx_filename	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   45.38%   46.71%   +1.33%     
==========================================
  Files          18       21       +3     
  Lines        2937     3033      +96     
==========================================
+ Hits         1333     1417      +84     
- Misses       1604     1616      +12

Flag	Coverage Δ
python2.7	`51.40% <34.56%> (-0.70%)`	⬇️
python3.11	`51.49% <92.30%> (+1.34%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pylint

scripts/test_hfx_filename.py|45 col 4| C0116: Missing function or method docstring (missing-function-docstring)
scripts/test_hfx_filename.py|71 col 4| C0116: Missing function or method docstring (missing-function-docstring)
scripts/test_hfx_filename.py|84 col 4| C0116: Missing function or method docstring (missing-function-docstring)
scripts/test_hfx_filename.py|99| C0115: Missing class docstring (missing-class-docstring)
scripts/test_hfx_filename.py|101 col 4| C0116: Missing function or method docstring (missing-function-docstring)
scripts/test_hfx_filename.py|8| C0411: standard import "import sys" should be placed before "from mock import MagicMock, patch, call" (wrong-import-order)

github-actions · 2024-01-30T23:12:18Z

scripts/import_file.py

+
+def get_module(module_name, file_path):
+    testdir = os.path.dirname(__file__)
+    return import_from_file(module_name, testdir + file_path)


[pylint] _{reported by reviewdog 🐶}
C0304: Final newline missing (missing-final-newline)

github-actions · 2024-01-30T23:12:18Z

scripts/import_file.py

@@ -0,0 +1,24 @@
+# Used for importing a non-".py" file as a module


[pylint] _{reported by reviewdog 🐶}
C0114: Missing module docstring (missing-module-docstring)

github-actions · 2024-01-30T23:12:18Z

scripts/import_file.py

+    # Only for python3, but CI has python2 pytest check, so add this line
+    if sys.version_info.major == 2:
+        return None
+    from importlib import machinery, util


[pylint] _{reported by reviewdog 🐶}
C0415: Import outside toplevel (importlib.machinery, importlib.util) (import-outside-toplevel)

github-actions · 2024-01-30T23:12:18Z

scripts/import_file.py

+    spec.loader.exec_module(module)
+    return module
+
+def get_module(module_name, file_path):


[pylint] _{reported by reviewdog 🐶}
C0116: Missing function or method docstring (missing-function-docstring)

github-actions · 2024-01-30T23:12:18Z

scripts/test_hfx_filename.py

+@unittest.skipIf(sys.version_info < (3, 0), reason="requires python3")
+@patch("socket.socket")
+class TestRpc(unittest.TestCase):
+


[pylint] _{reported by reviewdog 🐶}
C0303: Trailing whitespace (trailing-whitespace)

github-actions · 2024-01-30T23:12:19Z

scripts/test_hfx_filename.py

+class TestParse(unittest.TestCase):
+
+    def test_parse_string(self): 
+        txt = "<value><array><data><value>success</value><value>abcde</value></data></array></value>" 


[pylint] _{reported by reviewdog 🐶}
C0301: Line too long (101/100) (line-too-long)

github-actions · 2024-01-30T23:12:19Z

scripts/test_hfx_filename.py

+        expected_txt = "abcde"
+        return_txt = hfx_filename.parse_string(txt)
+        self.assertEqual(expected_txt, return_txt)
+


[pylint] _{reported by reviewdog 🐶}
C0303: Trailing whitespace (trailing-whitespace)

github-actions · 2024-01-30T23:12:19Z

scripts/test_hfx_filename.py

@@ -0,0 +1,107 @@
+#!/usr/bin/env python3


[pylint] _{reported by reviewdog 🐶}
C0114: Missing module docstring (missing-module-docstring)

github-actions · 2024-01-30T23:12:20Z

scripts/test_hfx_filename.py

+
+@unittest.skipIf(sys.version_info < (3, 0), reason="requires python3")
+@patch("socket.socket")
+class TestRpc(unittest.TestCase):


[pylint] _{reported by reviewdog 🐶}
C0115: Missing class docstring (missing-class-docstring)

github-actions · 2024-01-30T23:12:20Z

scripts/test_hfx_filename.py

+@patch("socket.socket")
+class TestRpc(unittest.TestCase):
+
+    def test_rpc(self, mock_socket):


[pylint] _{reported by reviewdog 🐶}
C0116: Missing function or method docstring (missing-function-docstring)

github-actions · 2024-01-30T23:40:09Z

scripts/hfx_filename

@@ -55,13 +51,14 @@ def rpc(session_id, request):
        s.close()

 def parse_string(txt):
+    assert isinstance(txt, str):


[pylint] _{reported by reviewdog 🐶}
E0001: Parsing failed: 'invalid syntax (, line 54)' (syntax-error)

github-actions · 2024-01-30T23:40:09Z

scripts/perfmon

@@ -380,7 +380,7 @@ def get_percent_mem_usage(ignored):
        memlist = memfd.readlines()
        memfd.close()
        memdict = [ m.split(':', 1) for m in memlist ]
-        memdict = dict([(k.strip(), float(re.search('\d+', v.strip()).group(0))) for (k,v) in memdict])
+        memdict = dict([(k.strip(), float(re.search(r'\d+', v.strip()).group(0))) for (k,v) in memdict])


[pylint] _{reported by reviewdog 🐶}
C0301: Line too long (104/100) (line-too-long)

github-actions · 2024-01-30T23:40:09Z

scripts/test_hfx_filename.py

+
+
+@unittest.skipIf(sys.version_info < (3, 0), reason="requires python3")
+class TestParse(unittest.TestCase):


[pylint] _{reported by reviewdog 🐶}
C0115: Missing class docstring (missing-class-docstring)

github-actions · 2024-01-30T23:40:09Z

scripts/test_hfx_filename.py

+
+import unittest
+from mock import MagicMock, patch, call
+import sys


[pylint] _{reported by reviewdog 🐶}
C0411: standard import "import sys" should be placed before "from mock import MagicMock, patch, call" (wrong-import-order)

github-actions · 2024-01-30T23:40:09Z

scripts/test_perfmon.py

-    return import_from_file("perfmon", testdir + "/perfmon")
-
-perfmon = get_module()
+perfmon = get_module("perfmon", "/perfmon")
 @unittest.skipIf(sys.version_info < (3, 0), reason="requires python3")
 @patch("subprocess.getoutput")
 class TestGetPercentage(unittest.TestCase):


[pylint] _{reported by reviewdog 🐶}
C0115: Missing class docstring (missing-class-docstring)

github-actions · 2024-01-30T23:40:09Z

scripts/test_perfmon.py

@@ -5,35 +5,13 @@
 import unittest
 from mock import MagicMock, patch
 import sys


[pylint] _{reported by reviewdog 🐶}
C0411: standard import "import sys" should be placed before "from mock import MagicMock, patch" (wrong-import-order)

github-actions · 2024-01-30T23:40:09Z

scripts/test_perfmon.py

@@ -5,35 +5,13 @@
 import unittest
 from mock import MagicMock, patch
 import sys
-import os
-import subprocess
 import math


[pylint] _{reported by reviewdog 🐶}
C0411: standard import "import math" should be placed before "from mock import MagicMock, patch" (wrong-import-order)

github-actions · 2024-01-30T23:40:09Z

scripts/test_static_vdis.py

-    return import_from_file("static_vdis", testdir + "/static-vdis")
-
-static_vdis = get_module()
+static_vdis = get_module("static_vdis", "/static-vdis")

 @unittest.skipIf(sys.version_info < (3, 0), reason="requires python3")     
 class TestReadWriteFile(unittest.TestCase):


[pylint] _{reported by reviewdog 🐶}
C0115: Missing class docstring (missing-class-docstring)

github-actions · 2024-01-30T23:40:09Z

scripts/test_static_vdis.py

@@ -5,36 +5,14 @@
 import unittest
 from mock import MagicMock
 import sys


[pylint] _{reported by reviewdog 🐶}
C0411: standard import "import sys" should be placed before "from mock import MagicMock" (wrong-import-order)

github-actions · 2024-01-30T23:40:10Z

scripts/test_static_vdis.py

@@ -5,36 +5,14 @@
 import unittest
 from mock import MagicMock
 import sys
-import os
-import subprocess
 import tempfile


[pylint] _{reported by reviewdog 🐶}
C0411: standard import "import tempfile" should be placed before "from mock import MagicMock" (wrong-import-order)

github-actions · 2024-01-30T23:43:37Z

scripts/hfx_filename

    prefix = "<value><array><data><value>success</value><value>"
    if not txt.startswith(prefix):
-        raise "Unable to parse string response"
+        raise Exception("Unable to parse string response")


[pylint] _{reported by reviewdog 🐶}
W0719: Raising too general exception: Exception (broad-exception-raised)

github-actions · 2024-01-30T23:43:37Z

scripts/hfx_filename

    txt = txt[len(prefix):]
    suffix = "</value></data></array></value>"
    if not txt.endswith(suffix):
-        raise "Unable to parse string response"
+        raise Exception("Unable to parse string response")


[pylint] _{reported by reviewdog 🐶}
W0719: Raising too general exception: Exception (broad-exception-raised)

github-actions · 2024-01-30T23:44:02Z

scripts/test_hfx_filename.py

+        expected_return = "HelloWorld"
+        self.assertEqual(expected_return, body)
+
+    def test_rpc_international_character(self, mock_socket):


[pylint] _{reported by reviewdog 🐶}
C0116: Missing function or method docstring (missing-function-docstring)

github-actions · 2024-01-30T23:44:02Z

scripts/test_hfx_filename.py

+        expected_return = "HelloWorld"
+        self.assertEqual(expected_return, body)
+
+    def test_db_get_uuid(self, mock_socket):


[pylint] _{reported by reviewdog 🐶}
C0116: Missing function or method docstring (missing-function-docstring)

github-actions · 2024-01-30T23:44:02Z

scripts/test_hfx_filename.py

+        response = hfx_filename.db_get_by_uuid(0, "pool_patch", "22345")
+        self.assertEqual(expected_response, response)
+
+    def test_read_field(self, mock_socket):


[pylint] _{reported by reviewdog 🐶}
C0116: Missing function or method docstring (missing-function-docstring)

github-actions · 2024-01-30T23:44:02Z

scripts/test_hfx_filename.py

+@unittest.skipIf(sys.version_info < (3, 0), reason="requires python3")
+class TestParse(unittest.TestCase):
+
+    def test_parse_string(self): 


[pylint] _{reported by reviewdog 🐶}
C0116: Missing function or method docstring (missing-function-docstring)

stephenchengCloud and others added 2 commits January 30, 2024 18:21

CA-388295: Fix bugs from py2->py3 conversion in perfmon and hfx_filename

eda664d

Signed-off-by: Stephen Cheng <stephen.cheng@cloud.com>

Remove hfx_filename and perfmon from expected_to_fail

9216ab6

github-actions bot reviewed Jan 30, 2024

View reviewed changes

bernhardkaindl force-pushed the fixup-perfmon branch from 106b9f2 to 434073a Compare January 30, 2024 23:39

github-actions bot reviewed Jan 30, 2024

View reviewed changes

bernhardkaindl force-pushed the fixup-perfmon branch from 434073a to 3fb1ed0 Compare January 30, 2024 23:42

github-actions bot reviewed Jan 30, 2024

View reviewed changes

bernhardkaindl force-pushed the fixup-perfmon branch 2 times, most recently from a66e9e3 to 9216ab6 Compare January 30, 2024 23:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixup perfmon #10

Fixup perfmon #10

bernhardkaindl commented Jan 30, 2024

codecov-commenter commented Jan 30, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

github-actions bot Jan 30, 2024

		@@ -0,0 +1,24 @@
		# Used for importing a non-".py" file as a module



		@unittest.skipIf(sys.version_info < (3, 0), reason="requires python3")
		class TestParse(unittest.TestCase):

Fixup perfmon #10

Are you sure you want to change the base?

Fixup perfmon #10

Conversation

bernhardkaindl commented Jan 30, 2024

codecov-commenter commented Jan 30, 2024 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

codecov-commenter commented Jan 30, 2024 •

edited

Loading