Fixup perfmon.11 #11
Fixup perfmon.11 #11
Conversation
Signed-off-by: Stephen Cheng <stephen.cheng@cloud.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
scripts/hfx_filename
Outdated
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", variable has type "list[str]") [assignment]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", target has type "int") [assignment]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", target has type "int") [assignment]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", target has type "int") [assignment]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", target has type "int") [assignment]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in string interpolation (expression has type "Any | None", placeholder has type "int | float | SupportsFloat") [str-format]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Statement is unreachable [unreachable]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Non-overlapping equality check (left operand type: "bytes", right operand type: "Literal['refresh']") [comparison-overlap]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Non-overlapping equality check (left operand type: "bytes", right operand type: "Literal['debug_mem']") [comparison-overlap]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
If x = b'abc' then "%s" % x produces "b'abc'", not "abc". If this is desired behavior use "%r" % x. Otherwise, decode the bytes [str-bytes-safe]
| @@ -380,7 +380,7 @@ def get_percent_mem_usage(ignored): | |||
| memlist = memfd.readlines() | |||
| memfd.close() | |||
| memdict = [ m.split(':', 1) for m in memlist ] | |||
| memdict = dict([(k.strip(), float(re.search('\d+', v.strip()).group(0))) for (k,v) in memdict]) | |||
| memdict = dict([(k.strip(), float(re.search(r'\d+', v.strip()).group(0))) for (k,v) in memdict]) | |||
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "dict[str, float]", variable has type "list[list[str]]") [assignment]
| @@ -380,7 +380,7 @@ def get_percent_mem_usage(ignored): | |||
| memlist = memfd.readlines() | |||
| memfd.close() | |||
| memdict = [ m.split(':', 1) for m in memlist ] | |||
| memdict = dict([(k.strip(), float(re.search('\d+', v.strip()).group(0))) for (k,v) in memdict]) | |||
| memdict = dict([(k.strip(), float(re.search(r'\d+', v.strip()).group(0))) for (k,v) in memdict]) | |||
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Item "None" of "Match[str] | None" has no attribute "group" [union-attr]
| @@ -0,0 +1,24 @@ | |||
| # Used for importing a non-".py" file as a module | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)
| mock_socket.return_value = mock_connected_socket | ||
|
|
||
| header = "HTTP/1.1 200 OK\r\nContent-Length: 10\r\n\r\n" | ||
| body = "<value><array><data><value>success</value><value>HelloWorld</value></data></array></value>" |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0301: Line too long (107/98) (line-too-long)
| mock_socket.return_value = mock_connected_socket | ||
|
|
||
| header = "HTTP/1.1 200 OK\r\nContent-Length: 10\r\n\r\n" | ||
| body = "<value><array><data><value>success</value><value>file_name</value></data></array></value>" |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0301: Line too long (106/98) (line-too-long)
| class TestParse(unittest.TestCase): | ||
|
|
||
| def test_parse_string(self): | ||
| txt = "<value><array><data><value>success</value><value>abcde</value></data></array></value>" |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0301: Line too long (101/98) (line-too-long)
| @@ -0,0 +1,107 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)
|
|
||
| @unittest.skipIf(sys.version_info < (3, 0), reason="requires python3") | ||
| @patch("socket.socket") | ||
| class TestRpc(unittest.TestCase): |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0115: Missing class docstring (missing-class-docstring)
|
|
||
|
|
||
| @unittest.skipIf(sys.version_info < (3, 0), reason="requires python3") | ||
| class TestParse(unittest.TestCase): |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0115: Missing class docstring (missing-class-docstring)
|
|
||
| import unittest | ||
| from mock import MagicMock, patch, call | ||
| import sys |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0411: standard import "import sys" should be placed before "from mock import MagicMock, patch, call" (wrong-import-order)
pytype_reporter extracted 38 problem reports from pytype output.You can check the results of the job here |
No description provided.