Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for static IP #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jdgoldie
Copy link

@jdgoldie jdgoldie commented Jan 8, 2016

Rob,

I needed to build in a XEN Server in an environment where I have to use static IP. I added the ssh_host option and a setting for ip_getter that bypasses the VM IP discovery and uses the given value.

@rdobson
Copy link
Contributor

rdobson commented Aug 22, 2016

@jdgoldie thanks for the submission (apologies for the delayed response!)

I think that if a ssh_host is specified, the concept of the ip getter is not required, so I'd prefer not to add a new 'mode', rather, only use the ip getter in the case where an IP has not been specified (i.e. static).

Can we break out that change from the additional disk one? As you've pointed out, that needs a bit of a clean up which I might be able to help with if I get some time.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants