Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Spring DI, expire. Invert logic for getAll. #40

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Support for Spring DI, expire. Invert logic for getAll. #40

wants to merge 13 commits into from

Conversation

Bessonov
Copy link

Hi Jonathan,

nice work!

Commit "Explicit @SupportALL to use getAll()" (2fb5533) fix multiple SADD's (one for each field) and break api, because I thing it's better annotate (with @SupportALL) explicit if getAll needed. I'm not angry, if you disagree (I need this for my project to save space and load :-) ).

Commit "add expire" (ff037b1) is related to issue #36.

And small commit (4c73940) to allow use JOhm with Spring dependency injection with example in README.md (581e73e).

Best Regard,

Anton

@gsharma
Copy link
Contributor

gsharma commented Apr 21, 2011

Good stuff Anton! Can you please revert the code-formatting so we can examine the diff's? If you are an eclipse-user, please use this: https://github.com/gsharma/codestyles/blob/master/eclipseCodestyle.xml Thanks for also fixing issue 36. And I think an explicit SupportAll is a very good idea - your SupportAll has my support :)

@Bessonov
Copy link
Author

Do you mean d8d4db1 (dos2unix JOhmUtils.java, BasicPer...)? There is no changes here. I've used dos2unix, because someone checked windows-style-newlines in and it looks bad (http://img26.imageshack.us/img26/8238/screenshotby.png).

But if you will, I can revert it (or better: checkout you trunk and apply others commits to keep code cleaner).

@gsharma
Copy link
Contributor

gsharma commented May 2, 2011

That should have been me having made a change from another machine that was running windows. If you are using eclipse for an ide, after running dos2unix, you can run the eclipse code formatter: https://github.com/gsharma/codestyles/blob/master/eclipseCodestyle.xml

@Bessonov
Copy link
Author

Bessonov commented May 5, 2011

Done!

@asual
Copy link

asual commented Jun 1, 2011

Is there a chance for this patch to make it to the repository anytime soon? I'm eager to try the library in conjunction with Spring but if the project won't be maintained regularly then my only option is to start using the forked repository. The lack of official Maven artifact makes this decision even easier.

Thanks!

@gsharma
Copy link
Contributor

gsharma commented Jun 4, 2011

Yes, we are planning another JOhm release. It will also include an update to Jedis v2. mvn artifact is something we had explored last year but it would require a change to the package structure, so, we backed off on doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants