Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of DB id #222

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow override of DB id #222

wants to merge 2 commits into from

Conversation

mkysel
Copy link
Contributor

@mkysel mkysel commented Oct 15, 2024

During development it seems to be pretty common to change the nodeId from one to another. We have to nuke the DB to fix this.

Can we simply change the NodeId in the DB without catastrophic consequences?

@mkysel mkysel requested a review from a team as a code owner October 15, 2024 15:06
Copy link

graphite-app bot commented Oct 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “Queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “Hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case where the node ID changes, we want to do more than just skip the check. We want all messages in the database to be wiped. Otherwise we can get into a weird situation where you have messages originated from a node ID that doesn't exist, and other peers who are syncing from this node will have inconsistent records. That will make debugging sync issues much harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants