Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XCOMMONS-2174: Get rid of JDOM 1 dependency #1131

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

XCOMMONS-2174: Get rid of JDOM 1 dependency #1131

wants to merge 2 commits into from

Conversation

michitux
Copy link
Contributor

@michitux michitux commented Oct 18, 2024 •
edited
Loading

Jira URL

https://jira.xwiki.org/browse/XCOMMONS-2174

Changes

Description

  • Rewrite XML output in HTMLUtils using JDOM 2.
  • Make the helper class private to not expose JDOM 2 in the API.
  • Remove the dependency.

Clarifications

  • The class that was extended in the previous version is final in JDOM 2. Further, the methods that we're overriding are now in another class. Therefore, we're extending that class instead. To not repeat the mistake of exposing a dependency's API, I've made the nested class private.
  • This pull request depends on XWIKI-15705: Move to com.rometools version of the Rome API xwiki-platform#3576 and needs a vote for the breakage.

Screenshots & Video

No changes.

Executed Tests

In xwiki-commons (root):

LANG=C.UTF-8 mvn clean install -Pdocker,legacy,integration-tests,snapshotModules,quality,distribution,flavor-integration-tests

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None (breaking change)

@michitux
XCOMMONS-2174: Get rid of JDOM 1 dependency
aa41568 
* Rewrite XML output in HTMLUtils using JDOM 2.
* Make the helper class private to not expose JDOM 2 in the API.
* Remove the dependency.
tmortagne
tmortagne reviewed Oct 18, 2024
View reviewed changes
pom.xml Show resolved Hide resolved
@michitux
XCOMMONS-2174: Get rid of JDOM 1 dependency
20ef1b0 
* Enforce the use of JDOM 2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmortagne tmortagne tmortagne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michitux @tmortagne