Fix build failure on riscv64 caused by missing syscall #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On RISC-V 64-bit linux systems, syscall `dup2()` is not available, therefore
syscall.Dup2 will be undefined and gotop will fail to be built from soure.
This patch updates building target of logging/logging_{other,arm64} and
renames them based on syscall used.
10 tasks
|
Thank you. I'll have to take your word for it, as I don't have access to a RISCV machine. Sorry for the delay. I've gotten behind on merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. This is Camber from Anthon community and I am working on maintaining go-based packages in our distro's repository including gotop. I encountered a build failure on our riscv64 target and managed to write a patch for the issue.
On RISC-V 64-bit linux systems, syscall
dup2()is not available, thereforesyscall.Dup2will become undefined and gotop will fail to be built from source. This patch updates building target of logging/logging_{other,arm64} and renames them based on syscall used.I can personally confirm that the patch will solve aforementioned issue.
Reference: