Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added strokeWidth to GaugeArcStyle to allow control of arc thickness #58

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

niallermoran
Copy link

added strokeWidth to GaugeArcStyle to allow control of arc thickness

@yamin8000 yamin8000 self-requested a review September 22, 2024 12:00
@yamin8000
Copy link
Owner

added strokeWidth to GaugeArcStyle to allow control of arc thickness

I understand your concern but strokeWidth for arc should be constrained to the Gauge's size otherwise setting a fixed/arbitrary size for it causes it to be shown differently on different sizes. For instance, on smaller devices or even on smaller gauges on bigger devices we lose the desired gap between the arc and the Gauge's border, and the arc is thick compared to the total Gauge's size.

image

image

image

…auge size while respecting the variable set from parameter
Copy link

sonarcloud bot commented Sep 22, 2024

@yamin8000
Copy link
Owner

added strokeWidth to GaugeArcStyle to allow control of arc thickness

Other than that I see no problem with your pull request and it's a good addition to the library, thank you.

@yamin8000 yamin8000 merged commit 2631310 into yamin8000:master Sep 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants