Default to literal style for multiline strings #822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since many people complain about the defaulting to folded single quotes when a string has line breaks, I opened this PR for discussion.
It will now output stinggs as literal if it has line breaks.
Exceptions:
\n
)The test suite passes for me locally.
See the output for some examples before and after:
Code
Output in current main branch
Output in PR
For strings with multiple line breaks it now behaves like libyaml.
There are still differences to libyaml though.
Current PR:
libyaml:
So if there is only one line break, libyayml uses double quotes.
If we want that too, we would have to add another attribute to the ScalarAnalysis class, I think.