fix: apply child theme config recursively after providers register - #54
Closed
rivanuff wants to merge 1 commit into
Closed
fix: apply child theme config recursively after providers register#54rivanuff wants to merge 1 commit into
rivanuff wants to merge 1 commit into
Conversation
rivanuff
force-pushed
the
feat/recursive-child-config-merge
branch
2 times, most recently
from
August 31, 2026 13:51
6977f35 to
3a0288f
Compare
rivanuff
force-pushed
the
feat/recursive-child-config-merge
branch
from
August 31, 2026 13:55
3a0288f to
d571f61
Compare
Author
|
Closing: the recursive merge and the deferral both turn out to have org-wide impact. Audited all 57 repos requiring yard/nutshell. 18 have a child theme overriding a parent config key (250 file pairs). Of those, 26 pairs across 11 repos change substantively:
Separately, the deferral breaks child app.providers: RegisterProviders reads config('app.providers') at bootstrapper #5, the deferred callback runs at #6. gorinchem/werkenbij, roosendaal/participatieeiland and wilderszijde/leefstijl define providers in the child theme; wilderszijde would silently lose GoogleFontsServiceProvider. Moving the fix into package-meedoen instead, scoped to its own config key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.