Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. As well as JonathanHiggs in #54, I have a need to resolve const T types.
I tried his code and it allowed me to resolve an constructor argument of
std::shared_ptr<const T>
, but I couldn't compile simplycontainer->resolve<const T>()
.The necessary behavior is that a
std::shared_ptr<T>
is internally created when const T is required to resolve, sincestd::shared_ptr<T>
is convertible tostd::shared_ptr<const T>
.I've fixed some lines in
ComponentContext::tryToRegisterType()
to registerstd::remove_const_t<T>
instead of T itself.I hope I didn't make a mistake nor misunderstanding.
Thanks.