Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi-cursor support #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added multi-cursor support #24

wants to merge 3 commits into from

Conversation

ivan-kzn
Copy link

@ivan-kzn ivan-kzn commented Apr 9, 2024

added support of sharing multiple cursors via awareness messages

added support of sharing multiple cursors via awareness messages
@dmonad
Copy link
Member

dmonad commented Apr 9, 2024

This looks fine. But I ask that you find somebody else who can test that this actually works in different environments (Chrome, Firefox, Safari).

Is getSelections available in all browsers? As far as I know, most browsers don't support multi-selections.

One thing that I'm hesitant about is that this PR breaks compatibility with y-codemirror (in theory, you can currently sync content and awareness information with a codemirror instance). But I don't think this should be a blocker, unless someone finds a good reason.

@ivan-kzn
Copy link
Author

ivan-kzn commented May 3, 2024

ok, I'll test this functionality in browserstack and get back with results. btw we haven't met such issues for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants