Branch with several improvements #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional argument; if there is no outfile, the header of .ib file is hexdumped for all infiles
…unt its occurences in file
…IbFileData objects; added --hexdump and --print-analysis printout options
… of the actual files
…ccount; now for some phonebooks, header declared number of entries matches number of parsed entries
…e 16-byte ones, phone also not parsed correctly, however name is
…rsed in full (apart from those 16 bytes in size)
…(and there is no need for a "second pass"); also changes in the verbose printouts, so they are easier to control in this case
…ate it (which is not quite right) in parse_file_entries()
… merged_ipb_entries populating seems to work now
…is pass and report is done regardless; added --outjson which writes out .json file
…output; sort of merged_ipb_entries.sort case insensitive; removal of items with empty name/phone fields; and warnings for duplicate names, and duplicate phones, separately
…cate phone numbers now looks up substring (if string length of phone number > 6)
…f the name, and using it in intermediate name - now fewer name duplicates are detected
….vcf --outfile; works with --injson or with regular .ib file parsing
…o match the format accepted by Nokia 215 4G - confirmed it works; program done for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for starting this script! I know this repo is unmaintained, but I'm making this PR mostly just for awareness to this branch, which helped me merge contacts from multiple
phonebook.ibfiles from both Nokia 3310 3G and Nokia 220 4G, identify duplicates, and exported a .vcf file that Nokia 215 4G could accept.Though if you feel like it, you're more than welcome to merge :)
Thanks again!