Skip to content

Commit

Permalink
Revert "make tests use UTC time"
Browse files Browse the repository at this point in the history
This reverts commit d15a8c7.
  • Loading branch information
youngbryanyu committed Jan 16, 2024
1 parent d15a8c7 commit 3ed7446
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
2 changes: 1 addition & 1 deletion tests/simple-app-config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ describe('simple-app-config Tests', () => {

/* Check date against expected */
expect(dateVal instanceof Date).toBeTruthy;
expect(JSON.stringify((dateVal as Date).toISOString())).toBe('"1970-01-01T00:00:10.000Z"');
expect(JSON.stringify(dateVal)).toBe('"1970-01-01T00:00:10.000Z"');

/* Check regexp against expected */
expect(regexpVal instanceof RegExp).toBeTruthy;
Expand Down
4 changes: 3 additions & 1 deletion tests/utils/envParser.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@ describe('envParser Tests', () => {

/* Compare against expected */
expect(result instanceof Date).toBeTruthy();
expect((result as Date).toISOString()).toBe('1969-12-31T08:00:00.000Z');
expect(result.getUTCFullYear()).toBe(1969);
expect(result.getUTCMonth()).toBe(11); // Note: Months are 0-indexed in JavaScript Dates
expect(result.getUTCDate()).toBe(31);
});
});

Expand Down
14 changes: 9 additions & 5 deletions tests/utils/typeConverter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ describe('Type Converter Util Tests', () => {

/* Compare against expected */
expect(result instanceof Date).toBeTruthy();
expect((result as Date).toISOString()).toBe('1970-01-01T00:00:01.000Z');
expect(result.toJSON()).toBe('1970-01-01T00:00:01.000Z');
});

/* Test when converting to a Date is possible as a valid date string */
Expand All @@ -114,7 +114,9 @@ describe('Type Converter Util Tests', () => {

/* Compare against expected */
expect(result instanceof Date).toBeTruthy();
expect((result as Date).toISOString()).toBe('1969-12-31T08:00:00.000Z');
expect(result.getUTCFullYear()).toBe(1969);
expect(result.getUTCMonth()).toBe(11); // Note: Months are 0-indexed in JavaScript Dates
expect(result.getUTCDate()).toBe(31);
});

/* Test when converting to a Date is not possible */
Expand Down Expand Up @@ -243,9 +245,11 @@ describe('Type Converter Util Tests', () => {
expect(result[0] instanceof Date).toBeTruthy();
expect(result[1] instanceof Date).toBeTruthy();
expect(result[2] instanceof Date).toBeTruthy();
expect((result[0] as Date).toISOString()).toBe('1970-01-01T00:00:00.100Z');
expect((result[1] as Date).toISOString()).toBe('1969-12-31T08:00:00.000Z');
expect((result[2] as Date).toISOString()).toBe('1970-01-01T00:01:40.000Z');
expect(result[0].toJSON()).toBe('1970-01-01T00:00:00.100Z');
expect(result[1].getUTCFullYear()).toBe(1969);
expect(result[1].getUTCMonth()).toBe(11); // Note: Months are 0-indexed in JavaScript Dates
expect(result[1].getUTCDate()).toBe(31);
expect(result[2].toJSON()).toBe('1970-01-01T00:01:40.000Z');
});

/* Test when converting to a RegExp Array is possible */
Expand Down

0 comments on commit 3ed7446

Please sign in to comment.