Skip to content

Commit

Permalink
[#24433] YSQL: Remove flag workaround from YSQL major version upgrade…
Browse files Browse the repository at this point in the history
… tests

Summary:
Commit 7dffbbc worked around a performance issue on Mac release builds caused by commit 981415e, which set pg_client_use_shared_memory to true for release builds. Now that the performance issue has been removed by commit 555af7d, revert the workaround in the YSQL major upgrade shell tests.
Jira: DB-13340

Test Plan:
Jenkins: compile only

On MacOS 14 arm64:
  ./yb_build.sh release --sj
  pg15_tests/test_upgrade.sh

Reviewers: hsunder, fizaa, telgersma

Reviewed By: hsunder

Subscribers: ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D38978
  • Loading branch information
foucher committed Oct 14, 2024
1 parent b57d257 commit e1c8f7e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pg15_tests/common_upgrade.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ pghost3=127.0.0.$((ip_start + 2))

# TEST_always_return_consensus_info_for_succeeded_rpc=false is needed to upgrade a release build to
# debug.
# On MacOS, pg_client_use_shared_memory harms initdb performance significantly.
common_pg15_flags="TEST_always_return_consensus_info_for_succeeded_rpc=false,pg_client_use_shared_memory=false"
common_pg15_flags="TEST_always_return_consensus_info_for_succeeded_rpc=false"
# yb_enable_expression_pushdown=false is needed because the expression pushdown rewriter is not yet
# implemented.
common_tserver_flags='"ysql_pg_conf_csv=yb_enable_expression_pushdown=false"'
Expand Down

0 comments on commit e1c8f7e

Please sign in to comment.