Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YRB(.pres) support for language bundles #96

Closed
wants to merge 5 commits into from
Closed

Conversation

dmi3y
Copy link

@dmi3y dmi3y commented Aug 18, 2013

Basic support for YRB as it advertised in module intl re #94. Need to add some various tests and get cover them.

@dmi3y
Copy link
Author

dmi3y commented Aug 18, 2013

Whops, travis failed with weird error.

@@ -21,7 +21,7 @@ Documentation
Build Status
------------

[![Build Status](https://secure.travis-ci.org/yui/shifter.png?branch=master)](http://travis-ci.org/yui/shifter)
[![Build Status](https://secure.travis-ci.org/dmi3y/shifter.png?branch=master)](http://travis-ci.org/dmi3y/shifter)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this, please. We can't take this pull request because of this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I did not realize it will be included in request, that's my first pull request on github

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, no need to change this anyway, since all pushes to a given pull request branch will cause builds under yui3's Travis space.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am struggling with running tests on local env, so as intern solution trying to use travis (better than nothing). Thanks for comments, I will be back :)

@evocateur
Copy link
Contributor

Unit tests would go a long way toward convincing me this was good to pull. Ideally the coverage percentages would not drift significantly.

Also, you shouldn't be developing in your fork's master branch, it makes it much harder to keep up to date if the upstream moves under you. Pull requests work just as well from fork/working-branch as they do from fork/master.

@dmi3y
Copy link
Author

dmi3y commented Aug 19, 2013

Working on unit testings, also have to do take in count the branch convenience. So, possibly it would make sense close this pull request and open new in working-branch?

@dmi3y dmi3y closed this Aug 19, 2013
@evocateur
Copy link
Contributor

Yes, that would be simplest. In your local clone, you can branch easily by doing the following:

git checkout -b lang-support-pres master
git push -u origin lang-support-pres

You can then open a new pull request originating from your working branch. Pushing new commits will trigger yui3's Travis build, so you can verify that your local tests are valid in all target environments.

Once you've done that, restoring your clone's master to match upstream is a little more complicated:

git remote add upstream git@github.com:yui/shifter.git
git fetch upstream
git branch -D master
git checkout -b master upstream/master
git push -f -u origin master

The advantage of doing that is ease of syncing your working branches with the upstream master:

git checkout lang-support-pres
git pull upstream master
git push

@dmi3y
Copy link
Author

dmi3y commented Aug 19, 2013

Thanks Daniel for your help! Moving forward with modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants