Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: EditorConfig の設定を守っているか確認するCIを追加 #272

Closed
wants to merge 1 commit into from

Conversation

yutotnh
Copy link
Owner

@yutotnh yutotnh commented Aug 14, 2023

Issue

  • なし

対応内容

タイトルの通り

テスト

なし

残作業

なし

@yutotnh yutotnh added the enhancement New feature or request label Aug 14, 2023
@yutotnh yutotnh requested a review from grssbl August 14, 2023 03:59
@yutotnh yutotnh self-assigned this Aug 14, 2023
@yutotnh
Copy link
Owner Author

yutotnh commented Aug 14, 2023

下のコードも改行している部分のインデントが4の倍数でないからエラーに該当するみたい。
このエラーは今のところ許容できないので、EditorConfigのチェックの採用はしない。

参考コード

bool is_brake(StubPwmOut& pwmh, StubPwmOut& pwml)
{
    return ((fabsf(pwmh.read() - 1.00F) < FLT_EPSILON) && (fabsf(pwml.read() - 0.00F) < FLT_EPSILON)) ||
           ((fabsf(pwmh.read() - 0.00F) < FLT_EPSILON) && (fabsf(pwml.read() - 1.00F) < FLT_EPSILON));
}

@yutotnh
Copy link
Owner Author

yutotnh commented Aug 14, 2023

インデントはあきらめて(Clang-formatで十分)、それ以外の部分についてチェックする手段があればそれを今後採用する

@yutotnh yutotnh closed this Aug 14, 2023
@yutotnh yutotnh deleted the yutotnh-patch-2 branch August 14, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant