Update the RDP for svt #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxiangw
reviewed
Jun 23, 2023
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| import numpy as np | |||
| import math | |||
| from autodp import utils | |||
| from autodp import utils,logcomb, stable_logsumexp | |||
There was a problem hiding this comment.
Aren't "logcomb" and "stable_logsumexp" from autodp.utils?
yuxiangw
reviewed
Jun 23, 2023
| return ret_rdp | ||
| if sigma * np.sqrt(3) > sigma_nu * 2: | ||
| return ret_rdp | ||
| # The code below Implements Proposition 10 in NeurIPS-20 with gamma=2, which requires |
There was a problem hiding this comment.
Please include the arxiv / paper link. there are many papers in NeurIPS-20 and many of them may contain a proposition 10
yuxiangw
reviewed
Jun 23, 2023
| if sigma * np.sqrt(3) > sigma_nu * 2: | ||
| return ret_rdp | ||
| # The code below Implements Proposition 10 in NeurIPS-20 with gamma=2, which requires | ||
| # (1) sigma_nu * 2*L2> sqrt{3}sigma_rho *L2 (2) queries are non-negative. |
There was a problem hiding this comment.
How are you enforcing the non-negativity constraints so this will not be misused? A warning message or an "if" statement to check it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable varied choice on the noise to perturb threshold and the noise to perturb the query.