Add support for scaling on Nakadi metrics #6584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
force-pushed
the
nakadi-based-scaling
branch
4 times, most recently
from
743708a
to
7224bd6
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
mikkeloscar
force-pushed
the
nakadi-based-scaling
branch
from
7224bd6
to
5996419
Compare
mikkeloscar
added
the
major
mikkeloscar
changed the title
mikkeloscar
commented
Dec 7, 2023
| @@ -203,6 +203,8 @@ kube_metrics_adapter_default_scaling_window: "10m" | |||
| kube_metrics_adapter_scaling_schedule_ramp_steps: "5" | |||
| ## ZMON KairosDB URL | |||
| zmon_kairosdb_url: "https://data-service.zmon.zalan.do/kairosdb-proxy" | |||
| ## Nakadi URL (for the stats API) | |||
| nakadi_url: "" | |||
There was a problem hiding this comment.
note: actual URLs are defined in the internal repo.
|
👍 |
1 similar comment
|
👍🏻 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the kube-metrics-adapter to a version that supports scaling based on Nakadi metrics as documented in: https://github.com/zalando-incubator/kube-metrics-adapter?tab=readme-ov-file#nakadi-collector
Ref: zalando-incubator/kube-metrics-adapter#636