Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added roles endpoint #236

Merged
merged 7 commits into from
Aug 24, 2023
Merged

added roles endpoint #236

merged 7 commits into from
Aug 24, 2023

Conversation

matmccabe
Copy link
Contributor

Added roles endpoint, need review and some syntax troubleshooting for .rst file

@MrGeneration
Copy link
Member

Thank you for your contribution and your time.
Just to clarify. Is this a WIP PR or are you waiting for actual QA?

I've had a 10 minute look and fixed mayor issues. Already.
However, the code blocks cannot be lexed without enforcing as JSON (this is due to us providing a comment with the return code). Some of your return codes bring 4xx codes which doesn't look right. At least not if this is going to show up in the documentation.

Some payloads send to the API and their responses look mixed up as well.
At least I can't follow them - I'm not sure what happened there. 🙏

@ralf401
Copy link
Contributor

ralf401 commented Aug 22, 2023

Hi @matmccabe
thanks a lot for your contribution! I redacted your draft and commited it.

@mantas can you have a look if ok? Thank you!

@ralf401 ralf401 linked an issue Aug 22, 2023 that may be closed by this pull request
api/roles.rst Outdated Show resolved Hide resolved
api/roles.rst Outdated Show resolved Hide resolved
@ralf401 ralf401 requested a review from mantas August 23, 2023 11:15
index.rst Outdated Show resolved Hide resolved
@mantas
Copy link
Contributor

mantas commented Aug 23, 2023

@ralf401 Looks good. Good to merge besides that double link bit.

@ralf401 ralf401 merged commit e2145fa into zammad:main Aug 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation of roles API endpoint
4 participants