Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webuipoc: Integrate request-response API #5588

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

webuipoc: Integrate request-response API #5588

wants to merge 8 commits into from

Conversation

MZ-AD
Copy link
Contributor

@MZ-AD MZ-AD commented Jul 21, 2024 •
edited by thc202
Loading

@thc202 thc202 changed the title feat: Integrate request-response API webuipoc: Integrate request-response API Jul 22, 2024
@thc202
Copy link
Member

thc202 commented Jul 22, 2024

The branch has conflicts.

@thc202 thc202 mentioned this pull request Jul 23, 2024
Merged
@thc202
Copy link
Member

thc202 commented Jul 23, 2024 •
edited
Loading

The request/response header fields should be shown each on its own line (like in the desktop).

@MZ-AD
Copy link
Contributor Author

MZ-AD commented Jul 25, 2024

The request/response header fields should be shown each on its own line (like in the desktop).

image

Are you talking about this kind of separator, (Separated Head n Body)

@thc202
Copy link
Member

thc202 commented Jul 25, 2024

No, I mean each header field is in its own line (host: … in one line, User-Agent: … other line and so on). Compare to:
request-response
which have the host and user-agent in the same line (along the others).

@MZ-AD
feat: Integrate request-response API
368a114 
Signed-off-by: Moeez Ahmed <x311099@gmail.com>
@MZ-AD
Request components on separate lines
9b25df6 
Signed-off-by: Moeez Ahmed <x311099@gmail.com>
@thc202
Copy link
Member

thc202 commented Aug 8, 2024

Both the request and response header fields should be handled the same way.

@thc202
Copy link
Member

thc202 commented Aug 8, 2024 •
edited
Loading

They should also be aligned to the start of the line. And the bodies should keep their original indentation.

@MZ-AD
Copy link
Contributor Author

MZ-AD commented Aug 9, 2024

image

njmulsqb
njmulsqb reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@njmulsqb njmulsqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't split request/response body on the basis of new line ('\n')

MZ-AD and others added 2 commits August 9, 2024 10:32
@MZ-AD MZ-AD mentioned this pull request Aug 12, 2024
Open
10 tasks
@thc202
Copy link
Member

thc202 commented Aug 16, 2024

And the bodies should keep their original indentation.

This was not yet addressed.

@thc202
Copy link
Member

thc202 commented Aug 16, 2024

It would be better if it didn't show the response when it's empty (i.e. HTTP/1.0 0 )

@thc202 thc202 mentioned this pull request Aug 16, 2024
Open
MZ-AD and others added 2 commits August 29, 2024 17:48
@MZ-AD
Merge branch 'main' into request-response
6f35b28 
Signed-off-by: Moeez Ahmed <118293110+Moeez905@users.noreply.github.com>
@MZ-AD
fix: correct NodeIDProvider tag and clean up code
2e9e0d1 
Signed-off-by: Moeez Ahmed <x311099@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njmulsqb njmulsqb njmulsqb left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MZ-AD @thc202 @njmulsqb