ascanrules: add example alert to Cross Site Scripting (Persistent) #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
zapbot
added a commit
to zaproxy/cla
that referenced
this pull request
Aug 20, 2024
thc202
changed the title
thc202
reviewed
Aug 20, 2024
| @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Changed | |||
| - The Cross Site Scripting rule now includes example alert functionality for documentation generation purposes (Issue 6119) | |||
There was a problem hiding this comment.
- The Cross Site Scripting (Persistent) scan rule…
| .build()); | ||
| } | ||
|
|
||
| private AlertBuilder buildAlert( |
There was a problem hiding this comment.
The idea is to have the existing newAlert() calls to use this new method (adjusted as needed), to avoid duplication and ensure the example alerts match the raised alerts.
|
@uMorbeck should sign the CLA too or the commit's author amended. |
|
I have read the CLA Document and I hereby sign the CLA |
zapbot
added a commit
to zaproxy/cla
that referenced
this pull request
Aug 20, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding ascanrules for PersistentXssScanRule (Cross Site Scripting (Persistent) - A)
Related Issues
Part of zaproxy/zaproxy#6119.
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.