ascanrules: add SqlInjectionScanRule unit tests for boolean based #5797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
thc202
changed the title
thc202
reviewed
Oct 8, 2024
addOns/ascanrules/CHANGELOG.md
Outdated
Comment on lines
10
to
12
| ### Added | ||
| - Sql injection rule unit tests for boolean based attacks | ||
|
|
There was a problem hiding this comment.
Only changes affecting the user should be mentioned in the changelog, tests themselves not worth it.
| @@ -403,7 +403,7 @@ private static List<String> asList(String... strings) { | |||
| * *not* in the last where clause in a SQL query so as a result, the rest of the query needs to | |||
| * be closed off with the comment. | |||
| */ | |||
| private static final String[] SQL_LOGIC_AND_TRUE = { | |||
| public static final String[] SQL_LOGIC_AND_TRUE = { | |||
| @@ -93,287 +101,640 @@ void shouldReturnExpectedMappings() { | |||
| is(equalTo(CommonAlertTag.WSTG_V42_INPV_05_SQLI.getValue()))); | |||
| } | |||
|
|
|||
| @Test | |||
| void shouldTargetDbTech() { | |||
There was a problem hiding this comment.
It would have been better if this was done in a separate commit.
There was a problem hiding this comment.
Good point. I'll keep code reorganization separate from code changes going forward.
FiveOFive
force-pushed
the
sqli-boolean-based-unit-tests
branch
from
be5fde3
to
8fcb9d6
Compare
Signed-off-by: FiveOFive <FiveOFive@users.noreply.github.com>
FiveOFive
force-pushed
the
sqli-boolean-based-unit-tests
branch
from
8fcb9d6
to
ff7eae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Briefly describe the purpose, goals, and changes or improvements made in this pull request.
Related Issues
Specify any related issues or pull requests by linking to them. zaproxy/zaproxy#8652
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.