automation: Initialise default values #5811
Conversation
| Object value = writer.getMember().getValue(pojo); | ||
| if (value == null | ||
| || (value instanceof Collection && ((Collection<?>) value).isEmpty()) |
There was a problem hiding this comment.
We wouldn't need these checks if defaults are set correctly for all jobs. Also, for fields where the default is a non-null value or a non-empty list, these checks prevent the user from overriding those fields with a null/empty value.
| public static class Data extends JobData { | ||
| private Parameters parameters; | ||
| private final Parameters parameters; |
There was a problem hiding this comment.
Wdyt about moving parameters to JobData? That will ensure that we are consistent with the field name across jobs. Each job already provides its parameters (by overriding getParameters).
There was a problem hiding this comment.
We have to support backwards compatibility.
If thats maintained then we should go with whatever structure we think makes the most sense 😁
Oh, and without changing things to often 😉
There was a problem hiding this comment.
How is it going to be declared in the JobData? It's not the same type in all jobs, though they are all AutomationData.
There was a problem hiding this comment.
Right, I was thinking of using AutomationData...
But that can probably be in a separate PR. For this one I'll focus on the default values.
Signed-off-by: ricekot <git@ricekot.com>
ricekot
force-pushed
the
automation/init-defaults
branch
from
e075eb8
to
dbe25f3
Compare
ricekot
changed the title
Signed-off-by: ricekot <github@ricekot.com>
No description provided.