pscanrules: Address Suspicious Comments rule JS FPs #5813
+110
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
force-pushed
the
sus-comm-fp
branch
2 times, most recently
from
93a5cfd
to
031dd13
Compare
thc202
reviewed
Oct 13, 2024
| new AlertSummary( | ||
| pattern.toString(), | ||
| line, | ||
| Alert.CONFIDENCE_LOW, |
There was a problem hiding this comment.
I don't think we should be changing the confidence, we are still not extracting comments (e.g. "// FROM"), and IMO we should not be saying that we are checking comments, "likely comments".
kingthorin
force-pushed
the
sus-comm-fp
branch
2 times, most recently
from
e40a6e1
to
a1483ab
Compare
|
Tweaked |
kingthorin
commented
Oct 17, 2024
...va/org/zaproxy/zap/extension/pscanrules/InformationDisclosureSuspiciousCommentsScanRule.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
sus-comm-fp
branch
2 times, most recently
from
25d4dc4
to
abcb851
Compare
- CHANGELOG > Added fix note. - InformationDisclosureSuspiciousCommentsScanRule > Updated handling to target comments in JavaScript more specifically. - InformationDisclosureSuspiciousCommentsScanRuleUnitTest b> Updated and added tests. - Messages.properties > Updated to detail/report the findings more specifically based on the new behavior. - pscanrules.html > Correct occurrence of "add-on" (vs addon). Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
kingthorin
force-pushed
the
sus-comm-fp
branch
from
abcb851
to
ae5659e
Compare
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Note: The regexes used for JS comments are based on https://github.com/antlr/grammars-v4/blob/c82c128d980f4ce46fb3536f87b06b45b9619922/javascript/javascript/JavaScriptLexer.g4#L49-L50
Related Issues
Checklist
./gradlew spotlessApplyfor code formatting